From df6ba0e8246c23e18ad6aede46035c71de0b742f Mon Sep 17 00:00:00 2001
From: marin <postma.marin@protonmail.com>
Date: Tue, 1 Jun 2021 11:18:37 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Irevoire <tamo@meilisearch.com>
---
 meilisearch-http/src/index/dump.rs                     |  2 +-
 .../src/index_controller/dump_actor/loaders/v1.rs      | 10 +---------
 .../src/index_controller/dump_actor/mod.rs             |  2 +-
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/meilisearch-http/src/index/dump.rs b/meilisearch-http/src/index/dump.rs
index 247c02085..13e6cbc02 100644
--- a/meilisearch-http/src/index/dump.rs
+++ b/meilisearch-http/src/index/dump.rs
@@ -24,7 +24,7 @@ const DATA_FILE_NAME: &str = "documents.jsonl";
 
 impl Index {
     pub fn dump(&self, path: impl AsRef<Path>) -> anyhow::Result<()> {
-        // acquire write txn make sure any ongoing write is finnished before we start.
+        // acquire write txn make sure any ongoing write is finished before we start.
         let txn = self.env.write_txn()?;
 
         self.dump_documents(&txn, &path)?;
diff --git a/meilisearch-http/src/index_controller/dump_actor/loaders/v1.rs b/meilisearch-http/src/index_controller/dump_actor/loaders/v1.rs
index 89893998e..decd67f87 100644
--- a/meilisearch-http/src/index_controller/dump_actor/loaders/v1.rs
+++ b/meilisearch-http/src/index_controller/dump_actor/loaders/v1.rs
@@ -76,14 +76,6 @@ struct Settings {
     pub attributes_for_faceting: Option<Option<Vec<String>>>,
 }
 
-impl std::ops::Deref for Settings {
-    type Target = Option<Option<BTreeSet<String>>>;
-
-    fn deref(&self) -> &Self::Target {
-        &self.stop_words
-    }
-}
-
 fn load_index(
     src: impl AsRef<Path>,
     dst: impl AsRef<Path>,
@@ -128,7 +120,7 @@ fn load_index(
 
     // Finaly, we extract the original milli::Index and close it
     Arc::try_unwrap(index.0)
-        .map_err(|_e| "Couln't close index properly")
+        .map_err(|_e| "Couldn't close the index properly")
         .unwrap()
         .prepare_for_closing()
         .wait();
diff --git a/meilisearch-http/src/index_controller/dump_actor/mod.rs b/meilisearch-http/src/index_controller/dump_actor/mod.rs
index 0bddaf7a3..66f081e87 100644
--- a/meilisearch-http/src/index_controller/dump_actor/mod.rs
+++ b/meilisearch-http/src/index_controller/dump_actor/mod.rs
@@ -200,7 +200,7 @@ where
             let temp_dump_file = tempfile::NamedTempFile::new_in(&self.path)?;
             compression::to_tar_gz(temp_dump_path, temp_dump_file.path())?;
 
-            let dump_path = self.path.join(format!("{}.dump", self.uid));
+            let dump_path = self.path.join(self.uid).with_extension("dump");
             temp_dump_file.persist(&dump_path)?;
 
             Ok(dump_path)