From d85480de898d5f6b1c829fdd1fbed2bc381a1864 Mon Sep 17 00:00:00 2001
From: Mubelotix <simon@meilisearch.com>
Date: Tue, 1 Jul 2025 14:05:47 +0200
Subject: [PATCH] Move sort code out of facet

---
 crates/meilisearch/src/routes/indexes/documents.rs            | 4 ++--
 crates/milli/src/documents/mod.rs                             | 1 +
 .../src/{facet/facet_sort_recursive.rs => documents/sort.rs}  | 2 +-
 crates/milli/src/facet/mod.rs                                 | 1 -
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename crates/milli/src/{facet/facet_sort_recursive.rs => documents/sort.rs} (99%)

diff --git a/crates/meilisearch/src/routes/indexes/documents.rs b/crates/meilisearch/src/routes/indexes/documents.rs
index b66eec535..e8499a789 100644
--- a/crates/meilisearch/src/routes/indexes/documents.rs
+++ b/crates/meilisearch/src/routes/indexes/documents.rs
@@ -18,7 +18,7 @@ use meilisearch_types::error::deserr_codes::*;
 use meilisearch_types::error::{Code, ResponseError};
 use meilisearch_types::heed::RoTxn;
 use meilisearch_types::index_uid::IndexUid;
-use meilisearch_types::milli::facet::facet_sort_recursive::recursive_facet_sort;
+use meilisearch_types::milli::documents::sort::recursive_sort;
 use meilisearch_types::milli::update::IndexDocumentsMethod;
 use meilisearch_types::milli::vector::parsed_vectors::ExplicitVectors;
 use meilisearch_types::milli::{AscDesc, DocumentId};
@@ -1576,7 +1576,7 @@ fn retrieve_documents<S: AsRef<str>>(
     let facet_sort;
     let (it, number_of_documents) = if let Some(sort) = sort_criteria {
         let number_of_documents = candidates.len();
-        facet_sort = recursive_facet_sort(index, &rtxn, sort, &candidates)?;
+        facet_sort = recursive_sort(index, &rtxn, sort, &candidates)?;
         let iter = facet_sort.iter()?;
         (
             itertools::Either::Left(some_documents(
diff --git a/crates/milli/src/documents/mod.rs b/crates/milli/src/documents/mod.rs
index b515c4e98..7a4babfa8 100644
--- a/crates/milli/src/documents/mod.rs
+++ b/crates/milli/src/documents/mod.rs
@@ -4,6 +4,7 @@ pub mod geo_sort;
 mod primary_key;
 mod reader;
 mod serde_impl;
+pub mod sort;
 
 use std::fmt::Debug;
 use std::io;
diff --git a/crates/milli/src/facet/facet_sort_recursive.rs b/crates/milli/src/documents/sort.rs
similarity index 99%
rename from crates/milli/src/facet/facet_sort_recursive.rs
rename to crates/milli/src/documents/sort.rs
index 596ce6335..4008a37a4 100644
--- a/crates/milli/src/facet/facet_sort_recursive.rs
+++ b/crates/milli/src/documents/sort.rs
@@ -359,7 +359,7 @@ impl<'ctx> SortedDocuments<'ctx> {
     }
 }
 
-pub fn recursive_facet_sort<'ctx>(
+pub fn recursive_sort<'ctx>(
     index: &'ctx crate::Index,
     rtxn: &'ctx heed::RoTxn<'ctx>,
     sort: Vec<AscDesc>,
diff --git a/crates/milli/src/facet/mod.rs b/crates/milli/src/facet/mod.rs
index 8b0b9a25e..274d2588d 100644
--- a/crates/milli/src/facet/mod.rs
+++ b/crates/milli/src/facet/mod.rs
@@ -1,4 +1,3 @@
-pub mod facet_sort_recursive;
 mod facet_type;
 mod facet_value;
 pub mod value_encoding;