From 5130e06b419b591e39641de17dd62ac32f2ff261 Mon Sep 17 00:00:00 2001 From: Kerollmops Date: Wed, 23 Aug 2023 16:11:44 +0200 Subject: [PATCH 1/2] Temporarily disable an assert in the ranking rules --- milli/src/search/new/bucket_sort.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/milli/src/search/new/bucket_sort.rs b/milli/src/search/new/bucket_sort.rs index 248dc4f7a..7f1d4febe 100644 --- a/milli/src/search/new/bucket_sort.rs +++ b/milli/src/search/new/bucket_sort.rs @@ -91,11 +91,11 @@ pub fn bucket_sort<'ctx, Q: RankingRuleQueryTrait>( /// Update the universes accordingly and inform the logger. macro_rules! back { () => { - assert!( - ranking_rule_universes[cur_ranking_rule_index].is_empty(), - "The ranking rule {} did not sort its bucket exhaustively", - ranking_rules[cur_ranking_rule_index].id() - ); + // assert!( + // ranking_rule_universes[cur_ranking_rule_index].is_empty(), + // "The ranking rule {} did not sort its bucket exhaustively", + // ranking_rules[cur_ranking_rule_index].id() + // ); logger.end_iteration_ranking_rule( cur_ranking_rule_index, ranking_rules[cur_ranking_rule_index].as_ref(), From 8c0ebd13316efee9fd8466cd83c21a74422b7ab7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Wed, 23 Aug 2023 16:40:39 +0200 Subject: [PATCH 2/2] Update milli/src/search/new/bucket_sort.rs Co-authored-by: Louis Dureuil --- milli/src/search/new/bucket_sort.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/milli/src/search/new/bucket_sort.rs b/milli/src/search/new/bucket_sort.rs index 7f1d4febe..03e613b37 100644 --- a/milli/src/search/new/bucket_sort.rs +++ b/milli/src/search/new/bucket_sort.rs @@ -91,6 +91,7 @@ pub fn bucket_sort<'ctx, Q: RankingRuleQueryTrait>( /// Update the universes accordingly and inform the logger. macro_rules! back { () => { + // FIXME: temporarily disabled assert: see // assert!( // ranking_rule_universes[cur_ranking_rule_index].is_empty(), // "The ranking rule {} did not sort its bucket exhaustively",