diff --git a/milli/src/update/index_documents/transform.rs b/milli/src/update/index_documents/transform.rs index 8bedd778e..aef4d1583 100644 --- a/milli/src/update/index_documents/transform.rs +++ b/milli/src/update/index_documents/transform.rs @@ -840,9 +840,9 @@ impl<'a, 'i> Transform<'a, 'i> { original_obkv_buffer: &mut Vec, flattened_obkv_buffer: &mut Vec, ) -> Result<()> { - /// TODO do a XOR of the faceted fields - /// TODO if reindex_searchable returns true store all searchables else none - /// TODO no longer useful after Tamo's PR + // TODO do a XOR of the faceted fields + // TODO if reindex_searchable returns true store all searchables else none + // TODO no longer useful after Tamo's PR let mut old_fields_ids_map = settings_diff.old.fields_ids_map.clone(); let mut new_fields_ids_map = settings_diff.new.fields_ids_map.clone(); let mut obkv_writer = KvWriter::<_, FieldId>::memory(); diff --git a/milli/src/update/settings.rs b/milli/src/update/settings.rs index c7d6ff0fd..1529e1fe6 100644 --- a/milli/src/update/settings.rs +++ b/milli/src/update/settings.rs @@ -1099,14 +1099,8 @@ impl InnerIndexSettingsDiff { } pub fn reindex_searchable(&self) -> bool { - // TODO no longer useful after Tamo's PR - self.old - .fields_ids_map - .iter() - .zip(self.new.fields_ids_map.iter()) - .any(|(old, new)| old != new) - || self.old.stop_words.as_ref().map(|set| set.as_fst().as_bytes()) - != self.new.stop_words.as_ref().map(|set| set.as_fst().as_bytes()) + self.old.stop_words.as_ref().map(|set| set.as_fst().as_bytes()) + != self.new.stop_words.as_ref().map(|set| set.as_fst().as_bytes()) || self.old.allowed_separators != self.new.allowed_separators || self.old.dictionary != self.new.dictionary || self.old.user_defined_searchable_fields != self.new.user_defined_searchable_fields