searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-12-26 22:50:07 +01:00
Code Issues Releases Wiki Activity

FieldIdsMap no longer useful thanks to #4631

Browse Source
This commit is contained in:
Clément Renault 2024-05-22 16:06:15 +02:00
parent 500ddc76b5
commit bc5663e673
No known key found for this signature in database
GPG Key ID: F250A4C4E3AE5F5F
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
milli/src/update/index_documents/transform.rs
View File

@ -840,9 +840,9 @@ impl<'a, 'i> Transform<'a, 'i> {
original_obkv_buffer: &mut Vec<u8>,
flattened_obkv_buffer: &mut Vec<u8>,
) -> Result<()> {
/// TODO do a XOR of the faceted fields
/// TODO if reindex_searchable returns true store all searchables else none
/// TODO no longer useful after Tamo's PR
// TODO do a XOR of the faceted fields
// TODO if reindex_searchable returns true store all searchables else none
// TODO no longer useful after Tamo's PR
let mut old_fields_ids_map = settings_diff.old.fields_ids_map.clone();
let mut new_fields_ids_map = settings_diff.new.fields_ids_map.clone();
let mut obkv_writer = KvWriter::<_, FieldId>::memory();

10
milli/src/update/settings.rs
View File

@ -1099,14 +1099,8 @@ impl InnerIndexSettingsDiff {
}
pub fn reindex_searchable(&self) -> bool {
// TODO no longer useful after Tamo's PR
self.old
.fields_ids_map
.iter()
.zip(self.new.fields_ids_map.iter())
.any(|(old, new)| old != new)
|| self.old.stop_words.as_ref().map(|set| set.as_fst().as_bytes())
!= self.new.stop_words.as_ref().map(|set| set.as_fst().as_bytes())
self.old.stop_words.as_ref().map(|set| set.as_fst().as_bytes())
!= self.new.stop_words.as_ref().map(|set| set.as_fst().as_bytes())
|| self.old.allowed_separators != self.new.allowed_separators
|| self.old.dictionary != self.new.dictionary
|| self.old.user_defined_searchable_fields != self.new.user_defined_searchable_fields