searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-04 12:27:13 +02:00
Code Issues Releases Wiki Activity

Remove the write txn method from the index scheduler

Browse source
This commit is contained in:
Kerollmops 2025-06-10 14:03:05 +02:00
parent b32e30ad27
commit bbe802c656
No known key found for this signature in database
GPG key ID: F250A4C4E3AE5F5F
4 changed files with 23 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/meilisearch/src/routes/chats/settings.rs
View file

@ -42,8 +42,7 @@ async fn get_settings(
let ChatsParam { workspace_uid } = chats_param.into_inner();
// TODO do a spawn_blocking here ???
let rtxn = index_scheduler.read_txn()?;
let mut settings = match index_scheduler.chat_settings(&rtxn, &workspace_uid)? {
let mut settings = match index_scheduler.chat_settings(&workspace_uid)? {
Some(settings) => settings,
None => {
return Err(ResponseError::from_msg(
@ -68,8 +67,7 @@ async fn patch_settings(
let ChatsParam { workspace_uid } = chats_param.into_inner();
// TODO do a spawn_blocking here
let mut wtxn = index_scheduler.write_txn()?;
let old_settings = index_scheduler.chat_settings(&wtxn, &workspace_uid)?.unwrap_or_default();
let old_settings = index_scheduler.chat_settings(&workspace_uid)?.unwrap_or_default();
let prompts = match new.prompts {
Setting::Set(new_prompts) => DbChatCompletionPrompts {
@ -147,8 +145,7 @@ async fn patch_settings(
// );
settings.validate()?;
index_scheduler.put_chat_settings(&mut wtxn, &workspace_uid, &settings)?;
wtxn.commit()?;
index_scheduler.put_chat_settings(&workspace_uid, &settings)?;
settings.hide_secrets();
@ -165,11 +162,9 @@ async fn reset_settings(
index_scheduler.features().check_chat_completions("using the /chats/settings route")?;
let ChatsParam { workspace_uid } = chats_param.into_inner();
let mut wtxn = index_scheduler.write_txn()?;
if index_scheduler.chat_settings(&wtxn, &workspace_uid)?.is_some() {
if index_scheduler.chat_settings(&workspace_uid)?.is_some() {
let settings = Default::default();
index_scheduler.put_chat_settings(&mut wtxn, &workspace_uid, &settings)?;
wtxn.commit()?;
index_scheduler.put_chat_settings(&workspace_uid, &settings)?;
Ok(HttpResponse::Ok().json(settings))
} else {
Err(ResponseError::from_msg(