From b72495eb5892cf56d3b30b6d575491b1e80f6889 Mon Sep 17 00:00:00 2001 From: Tamo Date: Tue, 12 Mar 2024 18:19:02 +0100 Subject: [PATCH] fix the settings tests --- meilisearch/src/routes/indexes/settings.rs | 10 ++++++---- meilisearch/tests/settings/get_settings.rs | 4 +++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/meilisearch/src/routes/indexes/settings.rs b/meilisearch/src/routes/indexes/settings.rs index 1d03c9a91..41fc58a87 100644 --- a/meilisearch/src/routes/indexes/settings.rs +++ b/meilisearch/src/routes/indexes/settings.rs @@ -138,6 +138,7 @@ macro_rules! make_setting_route { debug!(returns = ?settings, "Update settings"); let mut json = serde_json::json!(&settings); + dbg!(&json); let val = json[$camelcase_attr].take(); Ok(HttpResponse::Ok().json(val)) @@ -625,14 +626,14 @@ fn embedder_analytics( } make_setting_route!( - "/search_cutoff", - patch, + "/search-cutoff", + put, u64, meilisearch_types::deserr::DeserrJsonError< meilisearch_types::error::deserr_codes::InvalidSettingsSearchCutoff, >, search_cutoff, - "search_cutoff", + "searchCutoff", analytics, |setting: &Option, req: &HttpRequest| { analytics.publish( @@ -673,7 +674,8 @@ generate_configure!( typo_tolerance, pagination, faceting, - embedders + embedders, + search_cutoff ); pub async fn update_all( diff --git a/meilisearch/tests/settings/get_settings.rs b/meilisearch/tests/settings/get_settings.rs index 000443f36..d573f38e0 100644 --- a/meilisearch/tests/settings/get_settings.rs +++ b/meilisearch/tests/settings/get_settings.rs @@ -35,6 +35,7 @@ static DEFAULT_SETTINGS_VALUES: Lazy> = Lazy::new(| "maxTotalHits": json!(1000), }), ); + map.insert("search_cutoff", json!(null)); map }); @@ -286,7 +287,8 @@ test_setting_routes!( ranking_rules put, synonyms put, pagination patch, - faceting patch + faceting patch, + search_cutoff put ); #[actix_rt::test]