searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-11-29 16:24:26 +01:00
Code Issues Releases Wiki Activity

Merge #3015

Browse Source 
3015: Replace deprecated set-output in GitHub actions r=curquiza a=funilrys

# Pull Request

This patch fixes #3011.

This patch fixes the deprecation warning regarding the usage of `set-output`.
This patch fixes the issues by switching the following format:

```
echo ::set-output name=[name]::[value]
```

into the following format:

```
echo "[name]=[value]" >> ${GITHUB_OUTPUT}
```


## Related issue
Fixes #3011

## What does this PR do?
- Fix CI/CD deprecation warnings.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: funilrys <contact@funilrys.com>
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
This commit is contained in:
bors[bot] 2022-11-10 09:45:55 +00:00 committed by GitHub
commit 9e189f5041
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/milestone-workflow.yml vendored
View File

@ -41,10 +41,10 @@ jobs:
echo version: $MILESTONE_VERSION echo version: $MILESTONE_VERSION
if [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.0$ ]]; then if [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.0$ ]]; then
echo 'This is NOT a patch release' echo 'This is NOT a patch release'
echo ::set-output name=is-patch::false echo "is-patch=false" >> $GITHUB_OUTPUT
elif [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then elif [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo 'This is a patch release' echo 'This is a patch release'
echo ::set-output name=is-patch::true echo "is-patch=true" >> $GITHUB_OUTPUT
else else
echo "Not a valid format of release, check the Milestone's title." echo "Not a valid format of release, check the Milestone's title."
echo 'Should be vX.Y.Z' echo 'Should be vX.Y.Z'

6
.github/workflows/publish-binaries.yml vendored
View File

@ -23,9 +23,9 @@ jobs:
escaped_tag=$(printf "%q" ${{ github.ref_name }}) escaped_tag=$(printf "%q" ${{ github.ref_name }})
if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo ::set-output name=stable::true echo "stable=true" >> $GITHUB_OUTPUT
else else
echo ::set-output name=stable::false echo "stable=false" >> $GITHUB_OUTPUT
fi fi
- name: Check release validity - name: Check release validity
if: github.event_name != 'schedule' && steps.check-tag-format.outputs.stable == 'true' if: github.event_name != 'schedule' && steps.check-tag-format.outputs.stable == 'true'
@ -66,7 +66,7 @@ jobs:
file: target/release/${{ matrix.artifact_name }} file: target/release/${{ matrix.artifact_name }}
asset_name: ${{ matrix.asset_name }} asset_name: ${{ matrix.asset_name }}
tag: ${{ github.ref }} tag: ${{ github.ref }}
publish-macos-apple-silicon: publish-macos-apple-silicon:
name: Publish binary for macOS silicon name: Publish binary for macOS silicon
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}

4
.github/workflows/publish-docker-images.yml vendored
View File

@ -25,9 +25,9 @@ jobs:
escaped_tag=$(printf "%q" ${{ github.ref_name }}) escaped_tag=$(printf "%q" ${{ github.ref_name }})
if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo ::set-output name=stable::true echo "stable=true" >> $GITHUB_OUTPUT
else else
echo ::set-output name=stable::false echo "stable=false" >> $GITHUB_OUTPUT
fi fi
# Check only the validity of the tag for official releases (not for pre-releases or other tags) # Check only the validity of the tag for official releases (not for pre-releases or other tags)