Smaller review changes

This commit is contained in:
Louis Dureuil 2024-05-22 12:26:00 +02:00
parent 3412e7fbcf
commit 8a941c0241
No known key found for this signature in database
4 changed files with 14 additions and 13 deletions

View file

@ -89,7 +89,7 @@ struct EmbedderVectorExtractor {
pub fn extract_vector_points<R: io::Read + io::Seek>(
obkv_documents: grenad::Reader<R>,
indexer: GrenadParameters,
settings_diff: Arc<InnerIndexSettingsDiff>,
settings_diff: &InnerIndexSettingsDiff,
) -> Result<Vec<ExtractedVectorPoints>> {
puffin::profile_function!();
@ -258,8 +258,6 @@ pub fn extract_vector_points<R: io::Read + io::Seek>(
}
}
/////
let mut results = Vec::new();
for EmbedderVectorExtractor {

View file

@ -241,7 +241,7 @@ fn send_original_documents_data(
let original_documents_chunk = original_documents_chunk.clone();
let lmdb_writer_sx = lmdb_writer_sx.clone();
rayon::spawn(move || {
match extract_vector_points(original_documents_chunk.clone(), indexer, settings_diff) {
match extract_vector_points(original_documents_chunk.clone(), indexer, &settings_diff) {
Ok(extracted_vectors) => {
for ExtractedVectorPoints {
manual_vectors,