From c2ceb8e41b1fe1ad08a109ce4bddf86391056c23 Mon Sep 17 00:00:00 2001 From: "Santhosh Reddy Vootukuri (SUNNY) (from Dev Box)" Date: Thu, 8 Aug 2024 07:31:46 -0700 Subject: [PATCH 1/8] Improve Integration tests in the file stats.rs --- crates/meilisearch/tests/index/stats.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index 291cb0ce0..274a0ab17 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -3,8 +3,8 @@ use crate::json; #[actix_rt::test] async fn stats() { - let server = Server::new().await; - let index = server.index("test"); + let server = Server::new_shared().await; + let index = server.unique_index(); let (task, code) = index.create(Some("id")).await; assert_eq!(code, 202); @@ -47,8 +47,8 @@ async fn stats() { #[actix_rt::test] async fn error_get_stats_unexisting_index() { - let server = Server::new().await; - let (response, code) = server.index("test").stats().await; + let server = Server::new_shared().await; + let (response, code) = server.unique_index().stats().await; let expected_response = json!({ "message": "Index `test` not found.", From d986a3bbafff822409ff33b8f7d4d71190ef192a Mon Sep 17 00:00:00 2001 From: "Santhosh Reddy Vootukuri (SUNNY) (from Dev Box)" Date: Thu, 8 Aug 2024 10:26:39 -0700 Subject: [PATCH 2/8] Changes to index and expected_response as per feedback --- crates/meilisearch/tests/index/stats.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index 274a0ab17..e2a96e101 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -47,11 +47,11 @@ async fn stats() { #[actix_rt::test] async fn error_get_stats_unexisting_index() { - let server = Server::new_shared().await; - let (response, code) = server.unique_index().stats().await; + let index = shared_does_not_exists_index(); + let (response, code) = index.stats().await; let expected_response = json!({ - "message": "Index `test` not found.", + "message": "Index `DOES_NOT_EXISTS` not found.", "code": "index_not_found", "type": "invalid_request", "link": "https://docs.meilisearch.com/errors#index_not_found" From 3e3c00f44cd0fe31a1afe6a681c405ff312bb96d Mon Sep 17 00:00:00 2001 From: "Santhosh Reddy Vootukuri (SUNNY) (from Dev Box)" Date: Mon, 12 Aug 2024 21:55:50 -0700 Subject: [PATCH 3/8] fix for test failure --- crates/meilisearch/tests/index/stats.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index e2a96e101..528be5dcb 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -1,4 +1,7 @@ -use crate::common::Server; +use crate::common::{ + shared_does_not_exists_index, shared_empty_index, shared_index_with_documents, Server, +}; + use crate::json; #[actix_rt::test] From 0e9040e605c865c9bac6facb5a49b4bcf390c3e3 Mon Sep 17 00:00:00 2001 From: "Santhosh Reddy Vootukuri (SUNNY) (from Dev Box)" Date: Tue, 13 Aug 2024 12:09:09 -0700 Subject: [PATCH 4/8] remove warnings --- crates/meilisearch/tests/index/stats.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index 528be5dcb..14ac82acf 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -1,5 +1,5 @@ use crate::common::{ - shared_does_not_exists_index, shared_empty_index, shared_index_with_documents, Server, + shared_does_not_exists_index, Server, }; use crate::json; From 248c90bad56f63641ec22d6b196780177587e144 Mon Sep 17 00:00:00 2001 From: "Santhosh Reddy Vootukuri (SUNNY) (from Dev Box)" Date: Sun, 8 Sep 2024 09:52:22 -0700 Subject: [PATCH 5/8] removing .await --- crates/meilisearch/tests/index/stats.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index 14ac82acf..282c42c3c 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -6,7 +6,7 @@ use crate::json; #[actix_rt::test] async fn stats() { - let server = Server::new_shared().await; + let server = Server::new_shared(); let index = server.unique_index(); let (task, code) = index.create(Some("id")).await; From 4cda584b0cc3476b391620bfd320161e95a908aa Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Fri, 16 May 2025 15:45:25 +0300 Subject: [PATCH 6/8] Fix the build of stats.rs Signed-off-by: Martin Tzvetanov Grigorov --- crates/meilisearch/tests/index/stats.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index 282c42c3c..40e3d312c 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -18,7 +18,7 @@ async fn stats() { assert_eq!(code, 200); assert_eq!(response["numberOfDocuments"], 0); - assert!(response["isIndexing"] == false); + assert_eq!(response["isIndexing"], false); assert!(response["fieldDistribution"].as_object().unwrap().is_empty()); let documents = json!([ @@ -42,7 +42,7 @@ async fn stats() { assert_eq!(code, 200); assert_eq!(response["numberOfDocuments"], 2); - assert!(response["isIndexing"] == false); + assert_eq!(response["isIndexing"], false); assert_eq!(response["fieldDistribution"]["id"], 2); assert_eq!(response["fieldDistribution"]["name"], 1); assert_eq!(response["fieldDistribution"]["age"], 1); @@ -50,7 +50,7 @@ async fn stats() { #[actix_rt::test] async fn error_get_stats_unexisting_index() { - let index = shared_does_not_exists_index(); + let index = shared_does_not_exists_index().await; let (response, code) = index.stats().await; let expected_response = json!({ From 3d130d31c882ba5c4217a0cad71cb778e05a65b6 Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Fri, 16 May 2025 15:49:50 +0300 Subject: [PATCH 7/8] Do not hard code the non-exiting index name/uid Signed-off-by: Martin Tzvetanov Grigorov --- crates/meilisearch/tests/index/stats.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index 40e3d312c..de594155b 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -54,7 +54,7 @@ async fn error_get_stats_unexisting_index() { let (response, code) = index.stats().await; let expected_response = json!({ - "message": "Index `DOES_NOT_EXISTS` not found.", + "message": format!("Index `{}` not found.", index.uid), "code": "index_not_found", "type": "invalid_request", "link": "https://docs.meilisearch.com/errors#index_not_found" From b2f2c5d69f4da23c568add932f101f06f335b162 Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Mon, 19 May 2025 14:44:08 +0300 Subject: [PATCH 8/8] Remove an assertion of a task uid. It differs for every run of the IT test suite. Format the imports Signed-off-by: Martin Tzvetanov Grigorov --- crates/meilisearch/tests/index/stats.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/crates/meilisearch/tests/index/stats.rs b/crates/meilisearch/tests/index/stats.rs index de594155b..90c77cec8 100644 --- a/crates/meilisearch/tests/index/stats.rs +++ b/crates/meilisearch/tests/index/stats.rs @@ -1,6 +1,4 @@ -use crate::common::{ - shared_does_not_exists_index, Server, -}; +use crate::common::{shared_does_not_exists_index, Server}; use crate::json; @@ -34,7 +32,6 @@ async fn stats() { let (response, code) = index.add_documents(documents, None).await; assert_eq!(code, 202); - assert_eq!(response["taskUid"], 1); index.wait_task(response.uid()).await.succeeded();