searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-11-29 08:14:26 +01:00
Code Issues Releases Wiki Activity

Add Setting API reminder in issue template

Browse Source 
When adding a new setting, there are several important points that can be easily forgotten.
This PR adds a small reminder list of some of these points.
This commit is contained in:
Many the fish 2024-01-15 11:19:13 +01:00 committed by GitHub
parent 5204c0b60b
commit 857cd09285
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.github/ISSUE_TEMPLATE/sprint_issue.md vendored
View File

@ -27,6 +27,14 @@ Related spec: WIP
- [ ] If prototype validated, merge changes into `main` - [ ] If prototype validated, merge changes into `main`
- [ ] Update the spec - [ ] Update the spec
## Impacted teams ### Reminders when modifying the Setting API
<!--- Special steps to remind when adding a new index setting -->
- [ ] Ensure the new setting route is at least tested by the [`test_setting_routes` macro](https://github.com/meilisearch/meilisearch/blob/5204c0b60b384cbc79621b6b2176fca086069e8e/meilisearch/tests/settings/get_settings.rs#L276)
- [ ] Ensure Analytics are fully implemented
- [ ] `/settings/my-new-setting` configurated in the [`make_setting_routes` macro](https://github.com/meilisearch/meilisearch/blob/5204c0b60b384cbc79621b6b2176fca086069e8e/meilisearch/src/routes/indexes/settings.rs#L141-L165)
- [ ] global `/settings` route configurated in the [`update_all` function](https://github.com/meilisearch/meilisearch/blob/5204c0b60b384cbc79621b6b2176fca086069e8e/meilisearch/src/routes/indexes/settings.rs#L655-L751)
- [ ] Ensure the dump serializing is consistent with the `/settings` route serializing, e.g., enums case can be different (`camelCase` in route and `PascalCase` in the dump)
<!---Ping the related teams. Ask for the engine manager if any hesitation--> <!---Ping the related teams. Ask for the engine manager if any hesitation-->