searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-04 20:37:15 +02:00
Code Issues Releases Wiki Activity

Introduce a parameter to disable the engine to autogenerate docids

Browse source
This commit is contained in:
Kerollmops 2020-10-31 21:46:55 +01:00
parent 21b4d60101
commit 6d52c5b2f0
No known key found for this signature in database
GPG key ID: 92ADA4E935E71FA4
2 changed files with 83 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/update/index_documents/transform.rs
View file

@ -33,6 +33,7 @@ pub struct Transform<'t, 'i> {
pub max_nb_chunks: Option<usize>,
pub max_memory: Option<usize>,
pub index_documents_method: IndexDocumentsMethod,
pub autogenerate_docids: bool,
}
impl Transform<'_, '_> {
@ -57,7 +58,14 @@ impl Transform<'_, '_> {
None => {
match documents.get(0).and_then(|doc| doc.keys().find(|k| k.contains("id"))) {
Some(key) => fields_ids_map.insert(&key).context("field id limit reached")?,
None => fields_ids_map.insert("id").context("field id limit reached")?,
None => {
if !self.autogenerate_docids {
// If there is no primary key in the current document batch, we must
// return an error and not automatically generate any document id.
return Err(anyhow!("missing primary key"))
}
fields_ids_map.insert("id").context("field id limit reached")?
},
}
},
};
@ -130,6 +138,9 @@ impl Transform<'_, '_> {
_ => return Err(anyhow!("documents ids must be either strings or numbers")),
},
None => {
if !self.autogenerate_docids {
return Err(anyhow!("missing primary key"));
}
let uuid = uuid::Uuid::new_v4().to_hyphenated().encode_lower(&mut uuid_buffer);
Cow::Borrowed(uuid)
},
@ -180,11 +191,16 @@ impl Transform<'_, '_> {
let primary_key_field_id = match user_id_pos {
Some(pos) => fields_ids_map.id(&headers[pos]).expect("found the primary key"),
None => {
let id = fields_ids_map.insert("id").context("field id limit reached")?;
if !self.autogenerate_docids {
// If there is no primary key in the current document batch, we must
// return an error and not automatically generate any document id.
return Err(anyhow!("missing primary key"))
}
let field_id = fields_ids_map.insert("id").context("field id limit reached")?;
// We make sure to add the primary key field id to the fields ids,
// this way it is added to the obks.
fields_ids.push((id, usize::max_value()));
id
fields_ids.push((field_id, usize::max_value()));
field_id
},
};