From 6b1c262b7456ec864836028428a2f3db57fcaa3c Mon Sep 17 00:00:00 2001 From: vuthanhtung2412 Date: Tue, 25 Mar 2025 12:43:15 +0100 Subject: [PATCH] fix all tests --- crates/meilisearch/tests/vector/mod.rs | 2 +- crates/milli/src/update/new/indexer/write.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/meilisearch/tests/vector/mod.rs b/crates/meilisearch/tests/vector/mod.rs index 75b00127f..2ac1bbdac 100644 --- a/crates/meilisearch/tests/vector/mod.rs +++ b/crates/meilisearch/tests/vector/mod.rs @@ -201,7 +201,7 @@ async fn generate_default_user_provided_documents(server: &Server) -> Index { ]); let (value, code) = index.add_documents(documents, None).await; snapshot!(code, @"202 Accepted"); - index.wait_task(value.uid()).await.failed(); + index.wait_task(value.uid()).await.succeeded(); index } diff --git a/crates/milli/src/update/new/indexer/write.rs b/crates/milli/src/update/new/indexer/write.rs index 6f7e212b1..77cb84ab6 100644 --- a/crates/milli/src/update/new/indexer/write.rs +++ b/crates/milli/src/update/new/indexer/write.rs @@ -219,7 +219,7 @@ pub fn write_from_bbqueue( let mut embeddings = Embeddings::new(*dimensions); let all_embeddings = asvs.read_all_embeddings_into_vec(frame, aligned_embedding); // FIXME: /!\ Case where #embeddings is divisor of `dimensions` would still pass - if all_embeddings.len() % *dimensions != 0 { + if *dimensions!= 0 && all_embeddings.len() % *dimensions != 0 { return Err(Error::UserError(UserError::InvalidVectorDimensions { expected: *dimensions, found: all_embeddings.len(),