From 5b51e8a08361092c3d3525e96dc789a136dabbbf Mon Sep 17 00:00:00 2001 From: Tamo Date: Wed, 19 Mar 2025 12:37:14 +0100 Subject: [PATCH] simplify the sprint issue to only tell you to add a label on your PR --- .github/ISSUE_TEMPLATE/sprint_issue.md | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/sprint_issue.md b/.github/ISSUE_TEMPLATE/sprint_issue.md index fa558487e..30b5e16ff 100644 --- a/.github/ISSUE_TEMPLATE/sprint_issue.md +++ b/.github/ISSUE_TEMPLATE/sprint_issue.md @@ -23,16 +23,8 @@ Related product discussion: ### Are you modifying a database? -- [ ] If not, add the `no db change` label to your PR, and you're good to go. -- [ ] If yes, add the `db change` label to your PR and you're good to go. - - [ ] /!\ Ensure all the read operations still work! - - If the change happened in milli, you may need to check the version of the database before doing any read operation - - If the change happened in the index-scheduler, make sure the new code can immediately read the old database - - If the change happened in the meilisearch-auth database, reach out to the team; we don't know yet how to handle these changes - - [ ] Write the code to go from the old database to the new one - - If the change happened in milli, the upgrade function should be written and called [here](https://github.com/meilisearch/meilisearch/blob/3fd86e8d76d7d468b0095d679adb09211ca3b6c0/crates/milli/src/update/upgrade/mod.rs#L24-L47) - - If the change happened in the index-scheduler, we've never done it yet, but the right place to do it should be [here](https://github.com/meilisearch/meilisearch/blob/3fd86e8d76d7d468b0095d679adb09211ca3b6c0/crates/index-scheduler/src/scheduler/process_upgrade/mod.rs#L13) - - [ ] Write an integration test [here](https://github.com/meilisearch/meilisearch/blob/main/crates/meilisearch/tests/upgrade/mod.rs) ensuring you can read the old database, upgrade to the new database, and read the new database as expected +- [ ] If not, add the `no db change` label to your PR, and you're good to merge. +- [ ] If yes, add the `db change` label to your PR. You'll receive a message explaining you what to do. ### Reminders when modifying the API