searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-06-10 18:11:41 +02:00
Code Issues Releases Wiki Activity

Reference PR in comments

Browse Source
This commit is contained in:
Louis Dureuil 2025-05-27 10:24:04 +02:00
parent b007ed6be9
commit 5810fb239f
No known key found for this signature in database
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/milli/src/prompt/error.rs
View File

@ -18,7 +18,7 @@ impl NewPromptError {
Self { kind: NewPromptErrorKind::CannotParseTemplate(inner), fault: FaultSource::User } Self { kind: NewPromptErrorKind::CannotParseTemplate(inner), fault: FaultSource::User }
} }
#[allow(unused)] #[allow(unused)] // See <https://github.com/meilisearch/meilisearch/pull/5593> for explanation
pub(crate) fn invalid_fields_in_template(inner: liquid::Error) -> NewPromptError { pub(crate) fn invalid_fields_in_template(inner: liquid::Error) -> NewPromptError {
Self { kind: NewPromptErrorKind::InvalidFieldsInTemplate(inner), fault: FaultSource::User } Self { kind: NewPromptErrorKind::InvalidFieldsInTemplate(inner), fault: FaultSource::User }
} }
@ -28,7 +28,7 @@ impl NewPromptError {
pub enum NewPromptErrorKind { pub enum NewPromptErrorKind {
#[error("cannot parse template: {0}")] #[error("cannot parse template: {0}")]
CannotParseTemplate(liquid::Error), CannotParseTemplate(liquid::Error),
#[allow(unused)] #[allow(unused)] // See <https://github.com/meilisearch/meilisearch/pull/5593> for explanation
#[error("template contains invalid fields: {0}. Only `doc.*`, `fields[i].name`, `fields[i].value` are supported")] #[error("template contains invalid fields: {0}. Only `doc.*`, `fields[i].name`, `fields[i].value` are supported")]
InvalidFieldsInTemplate(liquid::Error), InvalidFieldsInTemplate(liquid::Error),
} }

4
crates/milli/src/prompt/mod.rs
View File

@ -200,7 +200,7 @@ mod test {
} }
#[test] #[test]
#[ignore] #[ignore] // See <https://github.com/meilisearch/meilisearch/pull/5593> for explanation
fn template_missing_doc() { fn template_missing_doc() {
assert!(matches!( assert!(matches!(
Prompt::new("{{title}}: {{overview}}".into(), None), Prompt::new("{{title}}: {{overview}}".into(), None),
@ -231,7 +231,7 @@ mod test {
} }
#[test] #[test]
#[ignore] #[ignore] // See <https://github.com/meilisearch/meilisearch/pull/5593> for explanation
fn template_fields_invalid() { fn template_fields_invalid() {
assert!(matches!( assert!(matches!(
// intentionally garbled field // intentionally garbled field