From 43c8a206b43c61712e4a5a7861b82eecc2fc6ddb Mon Sep 17 00:00:00 2001 From: vuthanhtung2412 Date: Tue, 25 Mar 2025 13:07:17 +0100 Subject: [PATCH] detail comments --- crates/milli/src/update/new/indexer/write.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/milli/src/update/new/indexer/write.rs b/crates/milli/src/update/new/indexer/write.rs index 77cb84ab6..be8788ab0 100644 --- a/crates/milli/src/update/new/indexer/write.rs +++ b/crates/milli/src/update/new/indexer/write.rs @@ -218,7 +218,7 @@ pub fn write_from_bbqueue( arroy_writers.get(&embedder_id).expect("requested a missing embedder"); let mut embeddings = Embeddings::new(*dimensions); let all_embeddings = asvs.read_all_embeddings_into_vec(frame, aligned_embedding); - // FIXME: /!\ Case where #embeddings is divisor of `dimensions` would still pass + // FIXME: /!\ Case where number of embeddings is divisor of `dimensions` would still pass if *dimensions!= 0 && all_embeddings.len() % *dimensions != 0 { return Err(Error::UserError(UserError::InvalidVectorDimensions { expected: *dimensions,