From 428463e45c804a606b4576b500100407bbc5d02e Mon Sep 17 00:00:00 2001 From: Louis Dureuil Date: Wed, 2 Jul 2025 16:17:22 +0200 Subject: [PATCH] Check indexing fragments as well as search fragments --- crates/milli/src/vector/rest.rs | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/crates/milli/src/vector/rest.rs b/crates/milli/src/vector/rest.rs index 41e8ca9f9..7a16f1a1e 100644 --- a/crates/milli/src/vector/rest.rs +++ b/crates/milli/src/vector/rest.rs @@ -110,6 +110,13 @@ impl RequestData { Ok(if indexing_fragments.is_empty() && search_fragments.is_empty() { RequestData::Single(Request::new(request)?) } else { + for (name, value) in indexing_fragments { + JsonTemplate::new(value).map_err(|error| { + NewEmbedderError::rest_could_not_parse_template( + error.parsing(&format!(".indexingFragments.{name}")), + ) + })?; + } RequestData::FromFragments(RequestFromFragments::new(request, search_fragments)?) }) } @@ -614,14 +621,12 @@ impl RequestFromFragments { let search_fragments: Result<_, NewEmbedderError> = search_fragments .into_iter() .map(|(name, value)| { - Ok(( - name, - JsonTemplate::new(value).map_err(|error| { - NewEmbedderError::rest_could_not_parse_template( - error.parsing("searchFragments"), - ) - })?, - )) + let json_template = JsonTemplate::new(value).map_err(|error| { + NewEmbedderError::rest_could_not_parse_template( + error.parsing(&format!(".searchFragments.{name}")), + ) + })?; + Ok((name, json_template)) }) .collect();