From eaddee9fe2665aa2a73c5acfb22fd4bf22135095 Mon Sep 17 00:00:00 2001 From: Ferdinand Boas Date: Tue, 5 Oct 2021 18:07:59 +0200 Subject: [PATCH 1/4] Update CONTRIBUTING.md typo + text improvement all credits go to @guimachiavelli --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dff935894..0a7d17d95 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,9 +14,9 @@ It's [Hacktoberfest month](https://blog.meilisearch.com/contribute-hacktoberfest 🚀 If your PR gets accepted it will count into your participation to Hacktoberfest! -✅ To be accepted it has either to have been merged, approved or tagged with the `hacktoberest-accepted` label. +✅ To be accepted it has either to have been merged, approved or tagged with the `hacktoberfest-accepted` label. -🧐 Don't forget to check the [quality standards](https://hacktoberfest.digitalocean.com/resources/qualitystandards), otherwise your PR could be marked as `spam` or `invalid`, and it will not be counted toward your participation in Hacktoberfest. +🧐 Don't forget to check the [quality standards](https://hacktoberfest.digitalocean.com/resources/qualitystandards)! Low-quality PRs might get marked as `spam` or `invalid`, and will not count toward your participation in Hacktoberfest. ## Assumptions From 493a0e377dd39c780dbcce3bd38dde90360659a3 Mon Sep 17 00:00:00 2001 From: mpostma Date: Thu, 7 Oct 2021 11:49:52 +0200 Subject: [PATCH 2/4] optimize build size --- Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 44732839f..accea6de0 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -6,8 +6,8 @@ members = [ ] resolver = "2" -[profile.release] -debug = true +[build] +rustflags = "-C link-args=-s" [patch.crates-io] pest = { git = "https://github.com/pest-parser/pest.git", rev = "51fd1d49f1041f7839975664ef71fe15c7dcaf67" } From 14c6ae4735b4cab6dfcce79e592e935a2c9a06ba Mon Sep 17 00:00:00 2001 From: mpostma Date: Thu, 7 Oct 2021 12:10:36 +0200 Subject: [PATCH 3/4] disable stripping --- Cargo.toml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index accea6de0..02e9813a4 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -6,8 +6,5 @@ members = [ ] resolver = "2" -[build] -rustflags = "-C link-args=-s" - [patch.crates-io] pest = { git = "https://github.com/pest-parser/pest.git", rev = "51fd1d49f1041f7839975664ef71fe15c7dcaf67" } From 6c46fbbc57d2b63044e665bbe51343ff0d1f9efc Mon Sep 17 00:00:00 2001 From: Tom Parker-Shemilt Date: Sun, 10 Oct 2021 22:33:40 +0100 Subject: [PATCH 4/4] Remove memmap dependency --- Cargo.lock | 2 -- meilisearch-http/Cargo.toml | 1 - meilisearch-lib/Cargo.toml | 1 - 3 files changed, 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index cbb9e76f7..f27dc423a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1619,7 +1619,6 @@ dependencies = [ "meilisearch-error", "meilisearch-lib", "meilisearch-tokenizer", - "memmap", "mime", "num_cpus", "obkv", @@ -1685,7 +1684,6 @@ dependencies = [ "log", "meilisearch-error", "meilisearch-tokenizer", - "memmap", "milli", "mime", "num_cpus", diff --git a/meilisearch-http/Cargo.toml b/meilisearch-http/Cargo.toml index 88d00bfd1..f225a63a7 100644 --- a/meilisearch-http/Cargo.toml +++ b/meilisearch-http/Cargo.toml @@ -47,7 +47,6 @@ log = "0.4.14" meilisearch-lib = { path = "../meilisearch-lib" } meilisearch-error = { path = "../meilisearch-error" } meilisearch-tokenizer = { git = "https://github.com/meilisearch/tokenizer.git", tag = "v0.2.5" } -memmap = "0.7.0" mime = "0.3.16" num_cpus = "1.13.0" once_cell = "1.8.0" diff --git a/meilisearch-lib/Cargo.toml b/meilisearch-lib/Cargo.toml index 713d07fc3..bc50e3bb9 100644 --- a/meilisearch-lib/Cargo.toml +++ b/meilisearch-lib/Cargo.toml @@ -30,7 +30,6 @@ lazy_static = "1.4.0" log = "0.4.14" meilisearch-error = { path = "../meilisearch-error" } meilisearch-tokenizer = { git = "https://github.com/meilisearch/tokenizer.git", tag = "v0.2.5" } -memmap = "0.7.0" milli = { git = "https://github.com/meilisearch/milli.git", tag = "v0.17.0"} mime = "0.3.16" num_cpus = "1.13.0"