mirror of
https://github.com/meilisearch/MeiliSearch
synced 2025-07-03 20:07:09 +02:00
Regenerate embeddings more often:
- When `regenerate` was previously `false` and became `true` - When rendering the old version of the docs failed
This commit is contained in:
parent
933e319364
commit
396d76046d
1 changed files with 25 additions and 11 deletions
|
@ -141,6 +141,10 @@ impl<'extractor> Extractor<'extractor> for EmbeddingExtractor<'_, '_> {
|
||||||
context.new_fields_ids_map,
|
context.new_fields_ids_map,
|
||||||
&context.doc_alloc,
|
&context.doc_alloc,
|
||||||
)?;
|
)?;
|
||||||
|
let must_regenerate = if !old_vectors.regenerate {
|
||||||
|
// we just enabled `regenerate`
|
||||||
|
true
|
||||||
|
} else {
|
||||||
let old_rendered = prompt.render_document(
|
let old_rendered = prompt.render_document(
|
||||||
update.external_document_id(),
|
update.external_document_id(),
|
||||||
update.merged(
|
update.merged(
|
||||||
|
@ -150,8 +154,18 @@ impl<'extractor> Extractor<'extractor> for EmbeddingExtractor<'_, '_> {
|
||||||
)?,
|
)?,
|
||||||
context.new_fields_ids_map,
|
context.new_fields_ids_map,
|
||||||
&context.doc_alloc,
|
&context.doc_alloc,
|
||||||
)?;
|
);
|
||||||
if new_rendered != old_rendered {
|
|
||||||
|
if let Ok(old_rendered) = old_rendered {
|
||||||
|
// must regenerate if the rendered changed
|
||||||
|
new_rendered != old_rendered
|
||||||
|
} else {
|
||||||
|
// cannot check previous rendered, better regenerate
|
||||||
|
true
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
if must_regenerate {
|
||||||
chunks.set_autogenerated(
|
chunks.set_autogenerated(
|
||||||
update.docid(),
|
update.docid(),
|
||||||
update.external_document_id(),
|
update.external_document_id(),
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue