searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-01-08 12:34:30 +01:00
Code Issues Releases Wiki Activity

stop skipping empty tasks when adding documents

Browse Source
This commit is contained in:
Tamo 2024-12-30 17:48:25 +01:00
parent 970a489dcc
commit 33921747b7
No known key found for this signature in database
GPG Key ID: 20CD8020AFA88D69
3 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/index-scheduler/src/batch.rs
View File

@ -1312,9 +1312,7 @@ impl IndexScheduler {
if let DocumentOperation::Add(content_uuid) = operation { if let DocumentOperation::Add(content_uuid) = operation {
let content_file = self.file_store.get_update(*content_uuid)?; let content_file = self.file_store.get_update(*content_uuid)?;
let mmap = unsafe { memmap2::Mmap::map(&content_file)? }; let mmap = unsafe { memmap2::Mmap::map(&content_file)? };
if !mmap.is_empty() { content_files.push(mmap);
content_files.push(mmap);
}
} }
} }

5
crates/index-scheduler/src/utils.rs
View File

@ -291,7 +291,10 @@ impl IndexScheduler {
debug_assert!(old_task != *task); debug_assert!(old_task != *task);
debug_assert_eq!(old_task.uid, task.uid); debug_assert_eq!(old_task.uid, task.uid);
debug_assert!(old_task.batch_uid.is_none() && task.batch_uid.is_some()); debug_assert!(
old_task.batch_uid.is_none() && task.batch_uid.is_some(),
"\n==> old: {old_task:?}\n==> new: {task:?}"
);
if old_task.status != task.status { if old_task.status != task.status {
self.update_status(wtxn, old_task.status, |bitmap| { self.update_status(wtxn, old_task.status, |bitmap| {

20
crates/meilisearch/tests/documents/add_documents.rs
View File

@ -1225,7 +1225,25 @@ async fn add_no_documents() {
snapshot!(code, @"202 Accepted"); snapshot!(code, @"202 Accepted");
let task = server.wait_task(task.uid()).await; let task = server.wait_task(task.uid()).await;
let task = task.succeeded(); let task = task.succeeded();
snapshot!(task, @""); snapshot!(task, @r#"
{
"uid": "[uid]",
"batchUid": "[batch_uid]",
"indexUid": "kefir",
"status": "succeeded",
"type": "documentAdditionOrUpdate",
"canceledBy": null,
"details": {
"receivedDocuments": 0,
"indexedDocuments": 0
},
"error": null,
"duration": "[duration]",
"enqueuedAt": "[date]",
"startedAt": "[date]",
"finishedAt": "[date]"
}
"#);
} }
#[actix_rt::test] #[actix_rt::test]