From 185f2b8f742040ee46be03d22fb98719d5f330ac Mon Sep 17 00:00:00 2001 From: Louis Dureuil Date: Wed, 30 Apr 2025 17:28:59 +0200 Subject: [PATCH] Fix test now that lexicographic string comparisons are allowed --- crates/milli/src/search/facet/filter.rs | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/crates/milli/src/search/facet/filter.rs b/crates/milli/src/search/facet/filter.rs index 969f00ec0..c3eba8031 100644 --- a/crates/milli/src/search/facet/filter.rs +++ b/crates/milli/src/search/facet/filter.rs @@ -1288,28 +1288,24 @@ mod tests { let result = filter.evaluate(&rtxn, &index).unwrap(); assert!(result.contains(0)); let filter = Filter::from_str("price < inf").unwrap().unwrap(); - assert!(matches!( - filter.evaluate(&rtxn, &index), - Err(crate::Error::UserError(crate::error::UserError::InvalidFilter(_))) - )); + let result = filter.evaluate(&rtxn, &index).unwrap(); + // this is allowed due to filters with strings + assert!(result.contains(1)); let filter = Filter::from_str("price = NaN").unwrap().unwrap(); let result = filter.evaluate(&rtxn, &index).unwrap(); assert!(result.is_empty()); let filter = Filter::from_str("price < NaN").unwrap().unwrap(); - assert!(matches!( - filter.evaluate(&rtxn, &index), - Err(crate::Error::UserError(crate::error::UserError::InvalidFilter(_))) - )); + let result = filter.evaluate(&rtxn, &index).unwrap(); + assert!(result.contains(1)); let filter = Filter::from_str("price = infinity").unwrap().unwrap(); let result = filter.evaluate(&rtxn, &index).unwrap(); assert!(result.contains(2)); let filter = Filter::from_str("price < infinity").unwrap().unwrap(); - assert!(matches!( - filter.evaluate(&rtxn, &index), - Err(crate::Error::UserError(crate::error::UserError::InvalidFilter(_))) - )); + let result = filter.evaluate(&rtxn, &index).unwrap(); + assert!(result.contains(0)); + assert!(result.contains(1)); } #[test]