From 0e04c90abe3f8c6d3c0ac57cb870d0e816d8a714 Mon Sep 17 00:00:00 2001 From: mpostma Date: Mon, 4 Jan 2021 15:43:31 +0100 Subject: [PATCH] remove benches --- meilisearch-core/Cargo.toml | 4 - meilisearch-core/benches/search_benchmark.rs | 108 ------------------- 2 files changed, 112 deletions(-) delete mode 100644 meilisearch-core/benches/search_benchmark.rs diff --git a/meilisearch-core/Cargo.toml b/meilisearch-core/Cargo.toml index 7be946d1b..ac854a6c4 100644 --- a/meilisearch-core/Cargo.toml +++ b/meilisearch-core/Cargo.toml @@ -51,7 +51,3 @@ termcolor = "1.1.0" [target.'cfg(unix)'.dev-dependencies] jemallocator = "0.3.2" - -[[bench]] -name = "search_benchmark" -harness = false diff --git a/meilisearch-core/benches/search_benchmark.rs b/meilisearch-core/benches/search_benchmark.rs deleted file mode 100644 index 3a14ccf67..000000000 --- a/meilisearch-core/benches/search_benchmark.rs +++ /dev/null @@ -1,108 +0,0 @@ -#[cfg(test)] -#[macro_use] -extern crate assert_matches; - -use std::error::Error; -use std::fs::File; -use std::io::BufReader; -use std::iter; -use std::path::Path; -use std::sync::mpsc; - -use meilisearch_core::{Database, DatabaseOptions}; -use meilisearch_core::{ProcessedUpdateResult, UpdateStatus}; -use meilisearch_core::settings::{Settings, SettingsUpdate}; -use meilisearch_schema::Schema; -use serde_json::Value; - -use criterion::{criterion_group, criterion_main, Criterion, BenchmarkId}; - -fn prepare_database(path: &Path) -> Database { - let database = Database::open_or_create(path, DatabaseOptions::default()).unwrap(); - let db = &database; - - let (sender, receiver) = mpsc::sync_channel(100); - let update_fn = move |_name: &str, update: ProcessedUpdateResult| { - sender.send(update.update_id).unwrap() - }; - let index = database.create_index("bench").unwrap(); - - database.set_update_callback(Box::new(update_fn)); - - db.main_write::<_, _, Box>(|writer| { - index.main.put_schema(writer, &Schema::with_primary_key("id")).unwrap(); - Ok(()) - }).unwrap(); - - let settings_update: SettingsUpdate = { - let path = concat!(env!("CARGO_MANIFEST_DIR"), "/../datasets/movies/settings.json"); - let file = File::open(path).unwrap(); - let reader = BufReader::new(file); - let settings: Settings = serde_json::from_reader(reader).unwrap(); - settings.to_update().unwrap() - }; - - db.update_write::<_, _, Box>(|writer| { - let _update_id = index.settings_update(writer, settings_update).unwrap(); - Ok(()) - }).unwrap(); - - let mut additions = index.documents_addition(); - - let json: Value = { - let path = concat!(env!("CARGO_MANIFEST_DIR"), "/../datasets/movies/movies.json"); - let movies_file = File::open(path).expect("find movies"); - serde_json::from_reader(movies_file).unwrap() - }; - - let documents = json.as_array().unwrap(); - - for document in documents { - additions.update_document(document); - } - - let update_id = db.update_write::<_, _, Box>(|writer| { - let update_id = additions.finalize(writer).unwrap(); - Ok(update_id) - }).unwrap(); - - // block until the transaction is processed - let _ = receiver.into_iter().find(|id| *id == update_id); - - let update_reader = db.update_read_txn().unwrap(); - let result = index.update_status(&update_reader, update_id).unwrap(); - assert_matches!(result, Some(UpdateStatus::Processed { content }) if content.error.is_none()); - - database -} - -pub fn criterion_benchmark(c: &mut Criterion) { - let dir = tempfile::tempdir().unwrap(); - let database = prepare_database(dir.path()); - - let reader = database.main_read_txn().unwrap(); - let index = database.open_index("bench").unwrap(); - - let mut count = 0; - let query = "I love paris "; - - let iter = iter::from_fn(|| { - count += 1; - query.get(0..count) - }); - - let mut group = c.benchmark_group("searching in movies (19654 docs)"); - group.sample_size(10); - - for query in iter { - let bench_name = BenchmarkId::from_parameter(format!("{:?}", query)); - group.bench_with_input(bench_name, &query, |b, query| b.iter(|| { - let builder = index.query_builder(); - builder.query(&reader, Some(*query), 0..20).unwrap(); - })); - } - group.finish(); -} - -criterion_group!(benches, criterion_benchmark); -criterion_main!(benches);