From 8b0c4291ae81d3616090914a3d02ae4c7c4e1c48 Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Mon, 2 Jun 2025 08:29:15 +0300 Subject: [PATCH 1/3] tests: Fater stats::mod IT tests Use shared server + unique indices Related-to: https://github.com/meilisearch/meilisearch/issues/4840 Signed-off-by: Martin Tzvetanov Grigorov --- crates/meilisearch/tests/stats/mod.rs | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/crates/meilisearch/tests/stats/mod.rs b/crates/meilisearch/tests/stats/mod.rs index aee626460..f448d893f 100644 --- a/crates/meilisearch/tests/stats/mod.rs +++ b/crates/meilisearch/tests/stats/mod.rs @@ -6,8 +6,8 @@ use crate::common::Server; use crate::json; #[actix_rt::test] -async fn get_settings_unexisting_index() { - let server = Server::new().await; +async fn get_version() { + let server = Server::new_shared(); let (response, code) = server.version().await; assert_eq!(code, 200); let version = response.as_object().unwrap(); @@ -18,7 +18,7 @@ async fn get_settings_unexisting_index() { #[actix_rt::test] async fn test_healthyness() { - let server = Server::new().await; + let server = Server::new_shared(); let (response, status_code) = server.service.get("/health").await; assert_eq!(status_code, 200); @@ -27,8 +27,8 @@ async fn test_healthyness() { #[actix_rt::test] async fn stats() { - let server = Server::new().await; - let index = server.index("test"); + let server = Server::new_shared(); + let index = server.unique_index(); let (task, code) = index.create(Some("id")).await; assert_eq!(code, 202); @@ -55,7 +55,7 @@ async fn stats() { ]); let (response, code) = index.add_documents(documents, None).await; - assert_eq!(code, 202, "{}", response); + assert_eq!(code, 202, "{response}"); assert_eq!(response["taskUid"], 1); index.wait_task(response.uid()).await.succeeded(); @@ -78,8 +78,8 @@ async fn stats() { #[actix_rt::test] async fn add_remove_embeddings() { - let server = Server::new().await; - let index = server.index("doggo"); + let server = Server::new_shared(); + let index = server.unique_index(); let (response, code) = index .update_settings(json!({ @@ -216,8 +216,8 @@ async fn add_remove_embeddings() { #[actix_rt::test] async fn add_remove_embedded_documents() { - let server = Server::new().await; - let index = server.index("doggo"); + let server = Server::new_shared(); + let index = server.unique_index(); let (response, code) = index .update_settings(json!({ @@ -293,8 +293,8 @@ async fn add_remove_embedded_documents() { #[actix_rt::test] async fn update_embedder_settings() { - let server = Server::new().await; - let index = server.index("doggo"); + let server = Server::new_shared(); + let index = server.unique_index(); // 2 embedded documents for 3 embeddings in total // but no embedders are added in the settings yet so we expect 0 embedded documents for 0 embeddings in total From 930d5a09a842a453edb655759576c3ab195e6203 Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Mon, 2 Jun 2025 11:51:52 +0300 Subject: [PATCH 2/3] Use unique server + its own index for #stats() test Using a shared server will make this test fragile Signed-off-by: Martin Tzvetanov Grigorov --- crates/meilisearch/tests/stats/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/meilisearch/tests/stats/mod.rs b/crates/meilisearch/tests/stats/mod.rs index f448d893f..f44812014 100644 --- a/crates/meilisearch/tests/stats/mod.rs +++ b/crates/meilisearch/tests/stats/mod.rs @@ -27,8 +27,8 @@ async fn test_healthyness() { #[actix_rt::test] async fn stats() { - let server = Server::new_shared(); - let index = server.unique_index(); + let server = Server::new().await; + let index = server.index("test"); let (task, code) = index.create(Some("id")).await; assert_eq!(code, 202); From 0557a4dd2f3eaac2867384c269c0c9a7e2f23759 Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Mon, 2 Jun 2025 14:28:30 +0300 Subject: [PATCH 3/3] Trigger build Signed-off-by: Martin Tzvetanov Grigorov