From 9242ae8dd9fabdb2b057f3a1fbc79ecaff23de1c Mon Sep 17 00:00:00 2001 From: npotts Date: Sun, 10 Jan 2016 00:51:02 -0700 Subject: [PATCH] Be more explicit in what is geting bitshifted Signed-off-by: npotts --- convertors/mcp3008/mcp3008.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/convertors/mcp3008/mcp3008.go b/convertors/mcp3008/mcp3008.go index 9e31575..c34a40d 100644 --- a/convertors/mcp3008/mcp3008.go +++ b/convertors/mcp3008/mcp3008.go @@ -44,8 +44,7 @@ func (m *MCP3008) AnalogValueAt(chanNum int) (int, error) { data[1] = uint8(m.Mode)<<7 | uint8(chanNum)<<4 data[2] = 0 case Bits12: - //[0x06| (channel >> 2), channel << 6, 0] - data[0] = 0x06 | (uint8(chanNum) >> 2) + data[0] = (uint8(startBit) << 2) + (uint8(m.Mode) << 1) + (uint8(chanNum) >> 2) data[1] = uint8(chanNum) << 6 data[2] = 0 }