From 7809d9d6babbb6f45c94cf094848149953cb3ebe Mon Sep 17 00:00:00 2001 From: Karan Misra Date: Thu, 9 Jan 2014 02:41:50 +0530 Subject: [PATCH] servo: assume good defaults for minus and maxus (544 and 2400, as per the Arduino documentation: http://arduino.cc/en/Reference/ServoAttach) --- motion/servo/servo.go | 7 ++++++- samples/servo.go | 2 +- samples/servoblaster.go | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/motion/servo/servo.go b/motion/servo/servo.go index ec2f4f3..cc53dbe 100644 --- a/motion/servo/servo.go +++ b/motion/servo/servo.go @@ -7,6 +7,11 @@ import ( "github.com/kid0m4n/go-rpi/util" ) +const ( + minus = 544 + maxus = 2400 +) + // A PWM interface implements access to a pwm controller. type PWM interface { SetMicroseconds(channel int, us int) error @@ -22,7 +27,7 @@ type Servo struct { } // New creates a new Servo interface. -func New(pwm PWM, channel int, minus, maxus int) *Servo { +func New(pwm PWM, channel int) *Servo { return &Servo{ PWM: pwm, Channel: channel, diff --git a/samples/servo.go b/samples/servo.go index 67c95c1..8b9d76a 100644 --- a/samples/servo.go +++ b/samples/servo.go @@ -21,7 +21,7 @@ func main() { pwm.Debug = true defer pwm.Close() - servo := servo.New(pwm, 0, 500, 2500) + servo := servo.New(pwm, 0) servo.Debug = true c := make(chan os.Signal, 1) diff --git a/samples/servoblaster.go b/samples/servoblaster.go index b01a995..86b77f7 100644 --- a/samples/servoblaster.go +++ b/samples/servoblaster.go @@ -15,7 +15,7 @@ func main() { sb.Debug = true defer sb.Close() - servo := servo.New(sb, 0, 500, 2500) + servo := servo.New(sb, 0) servo.Debug = true c := make(chan os.Signal, 1)