From 2f2fcf87bc07ffd94b1ad1aa17062f94853ab73e Mon Sep 17 00:00:00 2001 From: Rahul Gopinath Date: Wed, 25 Dec 2019 10:10:53 +0100 Subject: [PATCH] Make sure that default_arg is not passed rather than checking for falsity ``` if not default_arg: ... ``` fails when `default_arg` can be assigned and still be false (implementing a `__bool__` or `__len__` etc). You dont want to overwrite the passed values. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index de542ef..f2a825a 100644 --- a/README.md +++ b/README.md @@ -2173,7 +2173,7 @@ def some_func(default_arg=[]): ```py def some_func(default_arg=None): - if not default_arg: + if default_arg is not None: default_arg = [] default_arg.append("some_string") return default_arg