From 4d30a45c9e96a07fc2af0d299dbfcd64d38a1ee9 Mon Sep 17 00:00:00 2001 From: cheddar Date: Fri, 4 Apr 2014 10:05:58 -0500 Subject: [PATCH 1/2] Remove opinion from Node.js .gitignore file This is a PR to remove the opinionated lines from the Node.js .gitignore file. I do not believe that Github's pre-baked .gitignore files should be promulgating opinions, especially in a community that is as fresh as the Node.js community. Questions of what should be checked in should be a decision made on an organization-by-organization basis, or left up to the individual. Github's inclusion of opinion in these files puts unnecessary authority behind that opinion, which can have the negative side-effect of people following without thinking. --- Node.gitignore | 2 -- 1 file changed, 2 deletions(-) diff --git a/Node.gitignore b/Node.gitignore index da23d0d4..336f730c 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -20,6 +20,4 @@ coverage build/Release # Dependency directory -# Deployed apps should consider commenting this line out: -# see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git node_modules From 9390b1072d66cd7ae77d286d58d5b2acb411d57d Mon Sep 17 00:00:00 2001 From: cheddar Date: Fri, 4 Apr 2014 17:33:30 -0500 Subject: [PATCH 2/2] Reintroduce link to npmjs And remove my own opinions... --- Node.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Node.gitignore b/Node.gitignore index 336f730c..e33a7f7d 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -20,4 +20,6 @@ coverage build/Release # Dependency directory +# Commenting this out is preferred by some people, see +# https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git node_modules