From d79a88b29f279d9b6614f790d1d2217350777b46 Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Thu, 2 Jan 2014 20:02:57 -0500 Subject: [PATCH 1/7] Refactor Node.gitignore with comments The "build" directory is lost in this refactor, as many JS projects do wish to include a minified/concatenated version of their source in the "build" folder in source control. --- Node.gitignore | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/Node.gitignore b/Node.gitignore index c84ba258..31237481 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -1,15 +1,28 @@ -lib-cov -*.seed +# Semi-general patterns + +## Logs +logs *.log + +## Runtime data +pids +*.pid +*.seed + +## Run / build output +results *.csv *.dat *.out -*.pid *.gz -pids -logs -results -build +# JS-specific patterns +## Directory for files generated by jscoverage/JSCover +lib-cov + +# Node-specific patterns + +## You may want to comment this out in certain scenarios: +## see http://www.futurealoof.com/posts/nodemodules-in-git.html node_modules From 935e9b456077ad38e681aac78bfbe4dfbc2c1c13 Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 7 Jan 2014 01:37:13 -0800 Subject: [PATCH 2/7] Clarify node_modules comment Now linking to the official npm FAQ entry (with tl;dr) rather than straight to mikeal's blog post --- Node.gitignore | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Node.gitignore b/Node.gitignore index 31237481..565755e9 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -23,6 +23,7 @@ lib-cov # Node-specific patterns -## You may want to comment this out in certain scenarios: -## see http://www.futurealoof.com/posts/nodemodules-in-git.html +## Dependency directory +## Deployed apps should consider commenting this line out: +## see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git node_modules From b0440f97cc6660181cb014f4c994a9868774106b Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 7 Jan 2014 01:49:40 -0800 Subject: [PATCH 3/7] Add build/Release to Node gitignore This re-covers the http://nodejs.org/api/addons.html case for which the "build" directory was added in 00686415c4, but doesn't break cross-environment projects that use the build directory for including concatenated/minified source. Mazel tov! --- Node.gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Node.gitignore b/Node.gitignore index 565755e9..f23872f6 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -23,6 +23,9 @@ lib-cov # Node-specific patterns +## Compiled binary addons (http://nodejs.org/api/addons.html) +build/Release + ## Dependency directory ## Deployed apps should consider commenting this line out: ## see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git From 8845a345c0d325b2cdd33c5b10b7cacb3a152cea Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 7 Jan 2014 02:27:32 -0800 Subject: [PATCH 4/7] Add `coverage` directory, rename coverage heading --- Node.gitignore | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Node.gitignore b/Node.gitignore index f23872f6..faa648a6 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -16,11 +16,14 @@ results *.out *.gz -# JS-specific patterns +# Code coverage patterns -## Directory for files generated by jscoverage/JSCover +## Directory for coverage-hooked libs generated by jscoverage/JSCover lib-cov +## Coverage directory used by tools like istanbul +coverage + # Node-specific patterns ## Compiled binary addons (http://nodejs.org/api/addons.html) From bdf8aec8f9844efc53910fea78db69370d1533a3 Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 7 Jan 2014 02:33:15 -0800 Subject: [PATCH 5/7] Add .grunt directory --- Node.gitignore | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Node.gitignore b/Node.gitignore index faa648a6..f391c619 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -24,7 +24,12 @@ lib-cov ## Coverage directory used by tools like istanbul coverage -# Node-specific patterns +# Other popular tool patterns + +## Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) +.grunt + +# NodeJS patterns ## Compiled binary addons (http://nodejs.org/api/addons.html) build/Release From f3f11fb2f1e77eb4ec22bf933239830090ff933e Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 7 Jan 2014 02:52:27 -0800 Subject: [PATCH 6/7] Node.gitignore: correct term for instrumentation --- Node.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Node.gitignore b/Node.gitignore index f391c619..d5003b93 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -18,7 +18,7 @@ results # Code coverage patterns -## Directory for coverage-hooked libs generated by jscoverage/JSCover +## Directory for instrumented libs generated by jscoverage/JSCover lib-cov ## Coverage directory used by tools like istanbul From 937523ae5082e8232968665c844dd63c5ee6846c Mon Sep 17 00:00:00 2001 From: Adam Roben Date: Fri, 28 Feb 2014 11:34:11 -0500 Subject: [PATCH 7/7] Reduce comments --- Node.gitignore | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/Node.gitignore b/Node.gitignore index d5003b93..3a73dd6c 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -1,40 +1,32 @@ -# Semi-general patterns - -## Logs +# Logs logs *.log -## Runtime data +# Runtime data pids *.pid *.seed -## Run / build output +# Run / build output results *.csv *.dat *.out *.gz -# Code coverage patterns - -## Directory for instrumented libs generated by jscoverage/JSCover +# Directory for instrumented libs generated by jscoverage/JSCover lib-cov -## Coverage directory used by tools like istanbul +# Coverage directory used by tools like istanbul coverage -# Other popular tool patterns - -## Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) +# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) .grunt -# NodeJS patterns - -## Compiled binary addons (http://nodejs.org/api/addons.html) +# Compiled binary addons (http://nodejs.org/api/addons.html) build/Release -## Dependency directory -## Deployed apps should consider commenting this line out: -## see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git +# Dependency directory +# Deployed apps should consider commenting this line out: +# see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git node_modules