From 24f6734840548fb0b7bbc23b617941f452cc28a6 Mon Sep 17 00:00:00 2001 From: Andreia Gaita Date: Tue, 8 Jan 2019 15:00:46 +0000 Subject: [PATCH 1/2] Unity: ignore mdb files and fix path to crashlytics file (it can be in other places) Unity projects targeting the 2.0/3.5 runtime or built with mono < v5.0 generate `mdb` files, not `pdb` files. Looks like the `crashlytics-build.properties` gets around in more than just the `StreamingAssets` folder, looking at [examples around the internets](https://github.com/auth0/sharelock-android/blob/master/app/src/main/assets/crashlytics-build.properties), so it should probably just be ignored as a filename. --- Unity.gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Unity.gitignore b/Unity.gitignore index e59f3c27..2959acb6 100644 --- a/Unity.gitignore +++ b/Unity.gitignore @@ -26,12 +26,14 @@ ExportedObj/ *.booproj *.svd *.pdb +*.mdb *.opendb *.VC.db # Unity3D generated meta files *.pidb.meta *.pdb.meta +*.mdb.meta # Unity3D generated file on crash reports sysinfo.txt @@ -41,5 +43,5 @@ sysinfo.txt *.unitypackage # Crashlytics generated file -Assets/StreamingAssets/crashlytics-build.properties +crashlytics-build.properties From 152f419973461706e30f4f7701baf7434da95a9b Mon Sep 17 00:00:00 2001 From: Andreia Gaita Date: Tue, 8 Jan 2019 15:12:43 +0000 Subject: [PATCH 2/2] Unity: Do not blanket-ignore specific plugins, that's a user choice Only people building Unity plugins will need to import the asset store tools plugin into their project, and it's a toss up whether they want to commit the tooling into their repo (they might or they might not want to, it highly depends on their workflow). The default .gitignore shouldn't be making this choice for these users. --- Unity.gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Unity.gitignore b/Unity.gitignore index 2959acb6..59580361 100644 --- a/Unity.gitignore +++ b/Unity.gitignore @@ -4,7 +4,9 @@ [Bb]uild/ [Bb]uilds/ [Ll]ogs/ -[Aa]ssets/AssetStoreTools* + +# Uncomment this line if you wish to ignore the asset store tools plugin +# [Aa]ssets/AssetStoreTools* # Visual Studio cache directory .vs/