From 2d111edfb0475c08d325a3cbebee0a9b8e54c351 Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 30 Sep 2014 22:17:25 -0700 Subject: [PATCH 1/2] Restore original comment about node_modules It's not the opinion of "some people", it's a conditional circumstance. Even proponents of checking node_modules into Git agree that you shouldn't do it when you're writing a module to be included as a dependency on npmjs.org: the advantage of checking node_modules into Git is only for fully-packaged apps, which is why the original comment was what it was. --- Node.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Node.gitignore b/Node.gitignore index 59d842ba..bf988676 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -20,7 +20,7 @@ coverage build/Release # Dependency directory -# Commenting this out is preferred by some people, see +# Deployed apps should consider commenting this line out: # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git- node_modules From 9988b4bfe0661a31f101911029b13d0451b0c319 Mon Sep 17 00:00:00 2001 From: "Stuart P. Bentley" Date: Tue, 11 Nov 2014 23:47:18 -0800 Subject: [PATCH 2/2] Let node_modules FAQ URL speak for itself --- Node.gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/Node.gitignore b/Node.gitignore index bf988676..e03d33ef 100644 --- a/Node.gitignore +++ b/Node.gitignore @@ -20,7 +20,6 @@ coverage build/Release # Dependency directory -# Deployed apps should consider commenting this line out: # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git- node_modules