1
0
mirror of https://github.com/github/choosealicense.com synced 2024-06-29 07:03:02 +02:00
choosealicense.com/spec
W. Trevor King af78adb4fe spec_helper: Restore case-insensitive matching in find_spdx
The previous case-insensitive matching was removed in e5f46faa (test
required spdx-ids against data from spdx, 2016-05-25, #418).  That
commit was designed [1] to allow case-sensitive matching as discussed
in [2].  But while I'm in favor of case-sensitive keys in spdx_list,
the case-sensitive match breaks script/check-approval which downcases
its argument since it was added in 8e56bb83 (add
script/check-approval, 2016-01-18, #318).

There are more notes on SPDX's plans for case sensitivity in [3], so
we should see a clearer policy there soon.  I'm arguing for
case-sensitive *display* with optional case-insensitive matching.  I
am optimistic that the SPDX will at least agree not to register short
IDs that only differ by case, which is all we need to make this
case-insensitive match safe here.

[1]: https://github.com/github/choosealicense.com/pull/418#issuecomment-221404630
[2]: https://github.com/benbalter/licensee/issues/72
[3]: https://github.com/spdx/spdx-spec/issues/63
2018-01-03 11:13:08 -08:00
..
ci_ruby_version_spec.rb mindlessly satisfy rubocop 0.48 2017-03-26 17:19:44 -07:00
license_bom_spec.rb whoops, test looking at wrong file extension 2017-11-19 11:13:21 -08:00
license_fields_spec.rb match _ fields, require preceding space (ex CECILL-2.1) 2018-01-02 14:35:04 -08:00
license_meta_spec.rb add test that this project's license detected as MIT 2017-12-30 15:38:31 -08:00
license_rules_spec.rb mindlessly satisfy rubocop 0.48 2017-03-26 17:19:44 -07:00
license_shown_spec.rb Add EPL-2.0 2017-11-24 14:15:52 -08:00
license_spec.rb mindlessly satisfy rubocop 0.48 2017-03-26 17:19:44 -07:00
license_wrap_spec.rb @benbalter review comments 2017-11-20 12:56:03 -08:00
self_license_spec.rb rubocop 2017-12-30 15:48:07 -08:00
spec_helper.rb spec_helper: Restore case-insensitive matching in find_spdx 2018-01-03 11:13:08 -08:00