Mike Linksvayer
f4b5e20cba
@benbalter review comments
2017-11-20 12:56:03 -08:00
Mike Linksvayer
48b00a5a6b
update license texts from #489 , avoid EPL-1.0 skip
2017-11-20 12:02:53 -08:00
Mike Linksvayer
dc00fc0ae5
rubocop
2017-11-19 12:33:01 -08:00
Mike Linksvayer
dc4c7215ca
don't count newline
2017-11-19 12:23:28 -08:00
Mike Linksvayer
fc3370e024
basic test for line length <= 78
2017-11-19 12:11:14 -08:00
Mike Linksvayer
bb49e4c1f7
whoops, test looking at wrong file extension
2017-11-19 11:13:21 -08:00
Mike Linksvayer
5e7b07f998
rm no longer relevant test
2017-10-25 09:34:49 -07:00
Mike Linksvayer
71aace0808
rubocop
2017-10-24 16:24:38 -07:00
Mike Linksvayer
d5c6d8d746
only look for unknown [] fields in first 1000 charcters
...
that's where they're likely to be, outside of examples at the end
of long licenses
still want to check as if there are unknown [] fields in first
1000 characters, might be a field that should be filled in, but
wouldn't for lack of correct name
2017-10-24 14:51:39 -07:00
Mike Linksvayer
1726b836bb
make using
required for new licenses
2017-05-30 14:17:13 -07:00
Mike Linksvayer
aa33c8071b
satisfy rubocop 0.48.1
2017-04-08 22:40:27 -07:00
Mike Linksvayer
75c05d717c
mindlessly satisfy rubocop 0.48
2017-03-26 17:19:44 -07:00
Mike Linksvayer
f08ace3feb
make rubocop ruby version match pages ruby version
2017-01-18 13:31:19 -08:00
Mike Linksvayer
fad13d2de4
document fixing error in test output
...
https://github.com/github/choosealicense.com/pull/473#issuecomment-270185138
2017-01-04 08:53:18 -08:00
Mike Linksvayer
7de7b2c8ef
affirmative wording
...
https://github.com/github/choosealicense.com/pull/473#discussion_r94403400
2017-01-03 10:18:27 -08:00
Mike Linksvayer
7b4890ddf6
check .travis.yml ruby verison matches pages
...
https://github.com/github/choosealicense.com/pull/472#issuecomment-270048688
very rough, naive, probably bad implementation
2017-01-02 21:28:12 -08:00
Mike Linksvayer
570f69e4ec
hidden: false for 'popular' licenses
...
- document criteria for whether a license is hidden
- needed for license spectrum on /licenses OR
- on 'popular' list at https://opensource.org/licenses (some other list could be used in the future)
- adjust license properties and tests accordingly
This gets non-hidden list back close to what it was before #386 and (pending licensee vendoring this change, licensee release, and github.com licensee dependency version bump) some commonly requested licenses (eg #413 #449 ) will reappear in the github.com license drop-down.
2016-09-26 11:20:44 -07:00
Mike Linksvayer
cf79b35e06
re-add optional hidden field, default to true
...
licenses on /licenses have `hidden: false` set
fixes #434
2016-06-14 10:35:44 -07:00
Mike Linksvayer
b99e7ab017
replace 'id' variables with 'spdx_lcase' to minimize confusion
2016-06-01 08:36:56 -07:00
Mike Linksvayer
49fca01280
make tests not overwrite non-mutable document 'id'
2016-05-31 15:44:12 -07:00
Mike Linksvayer
e5f46faa30
test required spdx-ids against data from spdx
2016-05-25 08:53:23 -05:00
Mike Linksvayer
b4cf070a82
rm no longer pertinent fields and tests
2016-04-07 18:48:15 -07:00
Mike Linksvayer
810eeb5618
rename/order license properties better reflect how licenses work
...
and are structured
grant (permissions)
conditioned on (conditions)
with limitations
Permissions coming first combats mistaken but apparently widespread
impression that licenses impose conditions, even such that without
a license, there would be no conditions/work would be in the public
domain.
Requirements->Conditions emphasizes that they are pertinent if one
wants to take advantage of permissions.
Forbiddens->Limitations is more accurate: in most cases licenses
don't give permission to hold licensors liable, in some cases to
use licensors' trademarks or patents, but a licensee does not lose
the permissions granted by the license if the licensee holds licensor
liable, etc. Also emphasizes that there are limitatations on the
license grant, not that the license imposes prohibitions.
The most concise place to see both the rename and reorder is in
_includes/license-overview.html
I did not reorder the appearance of the groups of properties in
license source files (.txt files in _licenses) as those orderings
are not used to render anything on the webiste. Might do so later.
2016-03-01 13:33:15 -08:00
Mike Linksvayer
056bdf0580
fix style found by rubocop
2016-02-12 16:00:12 -08:00
Mike Linksvayer
c04ea11e17
Remove need for tab-slug
2016-02-12 15:51:44 -08:00
Ben Balter
2fb71d284a
Merge branch 'gh-pages' into jekyll-3-0-3
2016-02-09 12:26:24 -05:00
Ben Balter
8d24208088
Revert "upgrade to jekyll 3 due to"
...
This reverts commit 48c6e3e88785106d0a9357df8385f11891e85565.
2016-02-09 12:21:11 -05:00
Mike Linksvayer
e7f20659dd
Merge pull request #345 from github/open-licenses-test
...
Test that only open licenses are included per CONTRIBUTING
2016-02-09 09:06:51 -08:00
Mike Linksvayer
14896c3fc8
style feedback from @benbalter
2016-02-08 14:02:07 -08:00
Ben Balter
91b6c8728e
add rubocop
2016-02-08 15:37:19 -05:00
Mike Linksvayer
ade0beec17
Test that only open licenses are included per
...
https://github.com/github/choosealicense.com/blob/gh-pages/CONTRIBUTING.md#adding-a-license
- check that all licenses have minimum permissions
- remove non-open (and unused) forbiddens
- closes #1 with confidence
2016-02-08 10:25:06 -08:00
Mike Linksvayer
48c6e3e887
upgrade to jekyll 3 due to
...
https://github.com/blog/2100-github-pages-now-faster-and-simpler-with-jekyll-3-0
2016-02-02 16:02:01 -08:00
Ben Balter
41a9f1a9d7
use regex to check for BOM
2016-01-29 12:44:28 -05:00
Ben Balter
b9cdd8cb08
Merge branch 'gh-pages' into bom-test
2016-01-29 12:27:18 -05:00
Mike Linksvayer
6854e8aa86
Test each license file does not begin with byte order mark
...
Fixes #328
2016-01-28 17:19:42 -08:00
Mike Linksvayer
0fdcb2ca24
skipping no-license no longer pertinent as no-license is no-more
2016-01-28 15:11:42 -08:00
Mike Linksvayer
e98ec06a7d
consolidate no license info in /no-license, remove from /licenses
...
fixes #196
2016-01-26 13:42:29 -08:00
Ben Balter
78aa0e14c6
Merge pull request #324 from github/hidden-by-default
...
Make licenses hidden by default
2016-01-20 12:24:18 -05:00
Ben Balter
ad1c2d9684
Catch invalid SPDX IDs when looking for the SPPX name, fixes #322
2016-01-20 10:42:36 -05:00
Ben Balter
ed908356e7
make licenses hidden by default
2016-01-20 10:37:44 -05:00
Ben Balter
5531742d10
better error output
2016-01-20 10:20:04 -05:00
Ben Balter
e505eb8fb9
check if license is aleady a license
2016-01-18 17:05:02 -05:00
Ben Balter
c8012557a4
move FSF fix to the fsf_approved_licenses helper
2016-01-18 15:32:17 -05:00
Ben Balter
5e897e30b3
fix comment typo
2016-01-18 15:19:53 -05:00
Ben Balter
415ac8a174
fix spec
2016-01-15 18:01:07 -05:00
Ben Balter
853f4c97b2
check for license compliance
2016-01-15 17:40:32 -05:00
Waldir Pimenta
ba91c766d6
rename category --> family ( fix #288 )
2015-09-09 00:04:34 +01:00
Ben Balter
18ab25149b
add bsd-3-clause-clear to whitelist
2015-08-22 16:41:42 -04:00
Ben Balter
df0fd9213f
add rules spec
2015-08-22 15:42:12 -04:00
Ben Balter
26493bff3c
whitespace
2015-08-22 15:34:28 -04:00
Ben Balter
9b5db8a656
Merge branch 'gh-pages' into meta-cleanup
2015-08-22 15:33:46 -04:00
Ben Balter
ceb1a12158
rename to license_category
2015-08-22 15:27:15 -04:00
Ben Balter
915c08b821
move meta and fields to yaml
2015-08-22 15:25:16 -04:00
Ben Balter
8c63910daa
formalize whitelist
2015-08-22 12:41:30 -04:00
Ben Balter
2029405007
Revert "remove OSI appoval requirement"
...
This reverts commit 4b536ab4174a542dbfac7ee180d17349bf84d25d.
2015-08-22 12:36:56 -04:00
Ben Balter
4b536ab417
remove OSI appoval requirement
2015-08-19 17:30:11 -04:00
Ben Balter
530e15d771
validate SPDX compliance
2015-03-07 13:38:52 -05:00
Ben Balter
dc1cc773a1
add tests
2015-03-07 12:47:24 -05:00