From db878ed8f9120c56189265d480a37e1b3d9bc7ee Mon Sep 17 00:00:00 2001 From: Brandon Keepers Date: Tue, 17 Jan 2017 11:59:22 -0800 Subject: [PATCH 1/4] Check images for consistent use of http/https --- Rakefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Rakefile b/Rakefile index 9cf7614..412dcbb 100644 --- a/Rakefile +++ b/Rakefile @@ -13,7 +13,8 @@ task :test do HTMLProofer.check_directory('./_site', check_html: true, validation: { ignore_script_embeds: true }, - url_swap: { %r{http://choosealicense.com} => '' }).run + url_swap: { %r{http://choosealicense.com} => '' }, + check_img_http: true).run end task :approved_licenses do From 1a728bdd264f672e0ceda8ae8d735e13d32b7192 Mon Sep 17 00:00:00 2001 From: Mike Linksvayer Date: Tue, 17 Jan 2017 13:37:52 -0800 Subject: [PATCH 2/4] disable rubocop check new in 0.47 Avoid: ``` spec/license_spec.rb:3:1: C: Metrics/BlockLength: Block has too many lines. [40/25] describe 'licenses' do ... ^^^^^^^^^^^^^^^^^^^^^^ spec/license_spec.rb:8:3: C: Metrics/BlockLength: Block has too many lines. [35/25] licenses.each do |license| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/license_spec.rb:9:5: C: Metrics/BlockLength: Block has too many lines. [33/25] context "The #{license['title']} license" do ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` Doesn't seem worth refactoring, but happy to be wrong. --- .rubocop.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 07d01c1..6c5cba1 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,9 +1,12 @@ AllCops: - TargetRubyVersion: 2.1 + TargetRubyVersion: 2.3 Exclude: - _site/**/* - vendor/**/* +Metrics/BlockLength: + Enabled: false + Metrics/LineLength: Enabled: false From 472237f8723f2b839b1a580127856a0d52edd843 Mon Sep 17 00:00:00 2001 From: Mike Linksvayer Date: Tue, 17 Jan 2017 14:10:51 -0800 Subject: [PATCH 3/4] don't bump rubocop to 2.3 yet --- .rubocop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 6c5cba1..02d49ba 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,5 @@ AllCops: - TargetRubyVersion: 2.3 + TargetRubyVersion: 2.1 Exclude: - _site/**/* - vendor/**/* From 8360759d874d46283115eda499e6db40bcce8787 Mon Sep 17 00:00:00 2001 From: Mike Linksvayer Date: Wed, 18 Jan 2017 11:58:54 -0800 Subject: [PATCH 4/4] https in config/test strip, maybe no functional difference --- Rakefile | 2 +- _config.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Rakefile b/Rakefile index 412dcbb..7e2647e 100644 --- a/Rakefile +++ b/Rakefile @@ -13,7 +13,7 @@ task :test do HTMLProofer.check_directory('./_site', check_html: true, validation: { ignore_script_embeds: true }, - url_swap: { %r{http://choosealicense.com} => '' }, + url_swap: { %r{https://choosealicense.com} => '' }, check_img_http: true).run end diff --git a/_config.yml b/_config.yml index 74e1fce..e5d4e8d 100644 --- a/_config.yml +++ b/_config.yml @@ -3,7 +3,7 @@ title: Choose a License description: Non-judgmental guidance on choosing a license for your open source project relative_permalinks: false markdown: kramdown -url: "http://choosealicense.com" +url: "https://choosealicense.com" collections: licenses: